Attention is currently required from: Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61859 )
Change subject: drivers/smmstore/store.c: Fix static assertion for memory mapped SOCs ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
They're one and the same (for IFWI at least). […]
If the address is aligned in FMAP, then it won't be aligned when its memory-mapped and problems ensue.
APL and GLK will memory map the BIOS region (BP1 + BP2) at (0x100000000 - sizeof(BIOS)). And NvStorage has to be the last section.
An example, using this: https://review.coreboot.org/c/coreboot/+/60980/49/src/mainboard/starlabs/lit...
If you align SMMStore in FMAP at 0x690000, it will be memory mapped at 0xFFF41000 and doesn't work.