Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43492 )
Change subject: mb/amd/mandolin: fix DXIO lane numbers
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43492/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/43492/1/src/mainboard/amd/mandolin/...
PS1, Line 63: .start_lane
naming this start_logical_lane might be worth a thought; have to have a look how auto-generated the […]
done in CB:43660
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a90056d782d8d32fe34a0f5bdb61c3b61df1af8
Gerrit-Change-Number: 43492
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 15:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment