Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
(6 comments)
Looks like autoport hasn't been updated in a while. See inline comments how to fix building.
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 1: romstage-y += gpio.c add
bootblock-y += gpio.c
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 18: bd82x6x replace `bd82x6x` with `common`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 21: bd82x6x replace `bd82x6x` with `common`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/romstage.c:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 33: pch_enable_lpc rename to `mainboard_pch_lpc_setup`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 39: void mainboard_rcba_config(void) : { : } drop
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 60: void mainboard_early_init(int s3resume) : { : } : : void mainboard_config_superio(void) : { : } drop