Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36273/3/src/lib/cbmem_top.c File src/lib/cbmem_top.c:
https://review.coreboot.org/c/coreboot/+/36273/3/src/lib/cbmem_top.c@20 PS3, Line 20: return (void *)_cbmem_top_ptr; This symbol does not exist until CB:36274, technically this commit would fail to build.
I agree with the way different arch/ are split to followups commits, I just found this a bit confusing to review. A comment might be in order here to say program loader fills it in for us.
https://review.coreboot.org/c/coreboot/+/36273/3/src/lib/cbmem_top.c@27 PS3, Line 27: odd whitespace?