Attention is currently required from: Andrey Pronin, Paul Menzel, Julius Werner, Aaron Durbin. Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55242 )
Change subject: security/vboot: Add support for ZTE spaces ......................................................................
Patch Set 3:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55242/comment/0b50f6f0_e2b9a3e9 PS2, Line 16: successfully.
Please document how to do that.
Done
Patchset:
PS2:
Is successful create logged somehow?
Successful create is not explicitly logged, however TPM factory initialization successful is logged when all spaces are created.
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/55242/comment/6efaf46f_268c7053 PS2, Line 194: * should be rare (interru pted initialization), so no big harm
Stray tab.
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/4a397c24_f5ecbf31 PS2, Line 263: * Setup the Zero-Touch Enrollment(ZTE) related spaces.
Verb is spelled with a space: Set up.
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/f738d331_d804c38c PS2, Line 288: VBDEBUG("%s: Failed to setup RMA + SN Bits space\n", __func__);
set up
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/d62bb3f6_1c16c1bd PS2, Line 292: /* Setup Board ID */
Set up […]
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/0bba94be_99f0a5a7 PS2, Line 298: VBDEBUG("%s: Failed to setup Board ID space\n", __func__);
Set up (same below)
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/2c5e0f00_829c5de2 PS2, Line 302: /* Setup RMA Bytes counter */
Set up
Done
https://review.coreboot.org/c/coreboot/+/55242/comment/ae141d06_a5c22b94 PS2, Line 308: VBDEBUG("%s: Failed to define RMA Bytes space\n", __func__);
Use consistent wording (set up), and RMA Bytes Counter space.
I'd prefer to keep this separate. "Set up" as used above implies that the space is defined and initialized. Whereas here, the space is only being defined.
https://review.coreboot.org/c/coreboot/+/55242/comment/99cd35c7_effe69ad PS2, Line 352: * these are setup elsewhere via TPM vendor commands.
set up
Done