Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39599 )
Change subject: nb/intel/sandybridge: Tidy up code and comments ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Thank you for cleaning this all up.
https://review.coreboot.org/c/coreboot/+/39599/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39599/2//COMMIT_MSG@16 PS2, Line 16: - Use HOST_BRIDGE instead of PCI_DEV(0, 0, 0) Would have been nice as a separate commit on top.
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/mchbar_regs.h:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 16: Mention the data sheet name and revision?