EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37455 )
Change subject: libpayload/drivers/i8042: If configured ignore all i8042 init failures
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37455/4/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37455/4/payloads/libpayload/drivers...
PS4, Line 338: i8042_cmd(I8042_CMD_EN_KB);
I think your suggestion may have merit but I believe that we should move forward with this change an […]
Please check this CL:https://review.coreboot.org/c/coreboot/+/37594, it can avoid the same issue again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1c908b11afb8098a6cbbfa8a3d4391cabacd0f
Gerrit-Change-Number: 37455
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Dec 2019 07:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment