Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: Add Intel SkyLake Scalable Processor support ......................................................................
Patch Set 4:
(15 comments)
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... File src/soc/intel/skylake_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 701: hob->PlatformData.IIO_resource[socket].PcieInfo.PortInfo[p].Device;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 703: hob->PlatformData.IIO_resource[socket].PcieInfo.PortInfo[p].Function;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 720: current += acpi_create_dmar_ds_pci(current, bus, VMD_DEV_NUM, VMD_FUNC_NUM);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 764: u64 vtd_mmio_cap = *(volatile u64 *)(unsigned int) (vtd_base + VTD_EXT_CAP_LOW);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 783: u32 id = pci_mmio_read_config32(PCI_DEV(bus, dev, func), PCI_VENDOR_ID);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 848: hob->PlatformData.IIO_resource[socket].StackRes[stack].VtdBarAddress;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1003: acpigen_emit_byte(type_flags); // refer to ACPI Table 6-234 (Memory), 6-235 (IO), 6-236 (Bus) for details
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1022: const STACK_RES *ri = &hob->PlatformData.IIO_resource[socket].StackRes[stack];
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1024: snprintf(rtname, sizeof(rtname), "RT%02x", (socket*MAX_IIO_STACK)+stack);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1036: if (socket == 0 && stack == 0) { // additional io resources on socket 0 bus 0
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1041: acpigen_resource_word(1, 0xc, 0x3, 0, 0x0000, 0x03AF, 0, 0x03B0);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1042: acpigen_resource_word(1, 0xc, 0x3, 0, 0x03E0, 0x0CF7, 0, 0x0918);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1043: acpigen_resource_word(1, 0xc, 0x3, 0, 0x03B0, 0x03BB, 0, 0x000C);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1044: acpigen_resource_word(1, 0xc, 0x3, 0, 0x03C0, 0x03DF, 0, 0x0020);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/3/src/soc/intel/skylake_sp/ac... PS3, Line 1052: if (socket == 0 && stack == 0) { // additional mem32 resources on socket 0 bus 0
line over 96 characters
Done