Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19556 )
Change subject: pciexp_device: Prevent race condition with retrain link ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/19556/1//COMMIT_MSG Commit Message:
PS1, Line 9: The PCIe specification[1] describes a race condition that : can occur when using the Retrain Link bit in the Link : Control Register. : The race condition is avoided by checking the retrain link : bit in the link status register and waiting until it is : set to 0, before initiating a new link retraining.
Please add blank lines between paragraphs.
Done
https://review.coreboot.org/#/c/19556/1/src/device/pciexp_device.c File src/device/pciexp_device.c:
Line 56: /* Implementation note (page 633) in PCIe Specification 3.0 suggests
Nit: Since try needs to be initialised at the same value twice would for lo
Done
PS1, Line 56: /* Implementation note (page 633) in PCIe Specification 3.0 suggests : * polling the Link Training bit in the Link Status register until the : * value returned is 0 before setting the Retrain Link bit to 1. : * This is meant to avoid a race condition when using the : * Retrain Link mechanism. : */
Please use the style below.
Done