Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38463 )
Change subject: mainboard/system76: Add System76 Lemur Pro (lemp9) ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38463/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38463/6//COMMIT_MSG@16 PS6, Line 16: - Tianocore other payloads tested? If SeaBIOS non-functional, perhaps select Tianocore as default in Kconfig so as to have a sane default?
Also, Linux and Windows boot tested, or just the former?
https://review.coreboot.org/c/coreboot/+/38463/6//COMMIT_MSG@29 PS6, Line 29: GOP driver is recommended, VBT is provided assume display init works with both FSP/GOP init and a separate GOP driver in Tianocore?
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... PS6, Line 1: /* given you are running your own EC code, is the EC ACPI actually board specific? If not, perhaps better located in src/ec/system76/xxx/acpi/
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... PS6, Line 11: Enable Disable