Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36612 )
Change subject: arch/x86: Link .bss and .data in in-CAR stages
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36612/2/src/lib/program.ld
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/36612/2/src/lib/program.ld@128
PS2, Line 128: ENV_STAGE_IN_CAR
Not defined on non-x86. Probably best to inverse this logic in arch/x86/car.ld
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib165058abfb07e385461cdcca4aef31928ec7572
Gerrit-Change-Number: 36612
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Nov 2019 00:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment