21 Nov
2019
21 Nov
'19
1:47 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36517 )
Change subject: sc7180: Add SPI QUP driver ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo... PS5, Line 25: qup_spi_init(QUPV3_1_SE4, 1010 * KHz); /* EC SPI */ According to my schematics this should be QUPV3_1_SE0.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86f4fcff6f9537373f70a43711130d7f28bd5e09
Gerrit-Change-Number: 36517
Gerrit-PatchSet: 5
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment