[coreboot-gerrit] Change in coreboot[master]: soc/intel/adl: Add SKU specific power limits support

[Paul Menzel (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Rajasekhar Venkatanagapavan, Patrick Rudolph, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54676 )

Change subject: soc/intel/adl: Add SKU specific power limits support
......................................................................

Patch Set 6:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/54676/comment/7cb6cd41_6c79ef62 
PS6, Line 9: depends
depend

https://review.coreboot.org/c/coreboot/+/54676/comment/d804eaaa_1dbcf7d4 
PS6, Line 11: and 
remove

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/54676/comment/63aeedfa_079c5ea0 
PS6, Line 63: 	sa_pci_id = sa ? pci_read_config16(sa, PCI_DEVICE_ID) : 0xFFFF;
Move the assignments right before the switch statement?

https://review.coreboot.org/c/coreboot/+/54676/comment/d290c62f_0ef93c65 
PS6, Line 78: 	 */
You might want to use the concise style:

/* Choose a power limits configuration based on the SoC SKU type,
       differentiated here based on SA PCI ID. */

https://review.coreboot.org/c/coreboot/+/54676/comment/6518d8eb_c7e247a2 
PS6, Line 94: 			"configuration\n", sa_pci_id);
Please put the string on one line.