Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37802 )
Change subject: documentation: Add documentation on setting up mainboard GPIOs ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2: Code-Review+1
(2 comments)
Nice work, thanks!
There's something that is missing and should really be there: what happens when you configure a GPIO as output but is wired as an input? You risk short-circuiting something!
Another risk: setting an unconnected GPIO as an input without any pulls makes it end up floating, which is undesired.
That's a good idea, I'll add a section of "gotchas"
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start... File Documentation/getting_started/gpio.md:
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start... PS2, Line 15: before an SoC's memory : training step
before initializing the memory
Done
https://review.coreboot.org/c/coreboot/+/37802/2/Documentation/getting_start... PS2, Line 42: a list
an array
Done