build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39377 )
Change subject: amd/agesa/hudson: Do not write to DMA1_RESET_REG ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... File src/drivers/pc80/pc/isa-dma.c:
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... PS4, Line 42: printk(BIOS_DEBUG, "isa_dma_init: 0\n"); Prefer using '"%s...", __func__' to using 'isa_dma_init', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... PS4, Line 44: printk(BIOS_DEBUG, "isa_dma_init: 1\n"); Prefer using '"%s...", __func__' to using 'isa_dma_init', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... PS4, Line 46: printk(BIOS_DEBUG, "isa_dma_init: 2\n"); Prefer using '"%s...", __func__' to using 'isa_dma_init', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... PS4, Line 48: printk(BIOS_DEBUG, "isa_dma_init: 3\n"); Prefer using '"%s...", __func__' to using 'isa_dma_init', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/39377/4/src/drivers/pc80/pc/isa-dma... PS4, Line 50: printk(BIOS_DEBUG, "isa_dma_init: 4\n"); Prefer using '"%s...", __func__' to using 'isa_dma_init', this function's name, in a string