1 Feb
2022
1 Feb
'22
9:26 p.m.
Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Arthur Heymans, Nick Vaccaro, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61215 )
Change subject: device: Add support for PCIe Resizable BARs ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: Any thoughts on this one?
File src/include/device/pci_def.h:
https://review.coreboot.org/c/coreboot/+/61215/comment/e073758f_dfe3dfd9 PS2, Line 535: 0xe0
for easy understanding […]
Right now that macro isn't used in this file, so I didn't want to create inconsistencies.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14fcbe0ef09fdc7f6061bcf7439d1160d3bc4abf
Gerrit-Change-Number: 61215
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 01 Feb 2022 21:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment