Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35524 )
Change subject: mb/supermicro/x11: remove unneeded vendor id config ......................................................................
Patch Set 7: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/35524/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35524/1//COMMIT_MSG@9 PS1, Line 9: the default : value from the PCI Cfg
this was requested in the initial CR but neither did they give an explanation nor did they change an […]
Ack
https://review.coreboot.org/c/coreboot/+/35524/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35524/3//COMMIT_MSG@13 PS3, Line 13: 7e1c83). The right place would be the devicetree.
what is cf?
short for `confer`, actually: cf.
Usually, one specifies at least 7 chars of the commit hash. In any case git would be right, e.g.: git log --format='%h (%s)'
https://review.coreboot.org/c/coreboot/+/35524/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35524/7//COMMIT_MSG@9 PS7, Line 9: The vendor id option set here is useless as most SSVID registers are filled NB. Usual Git commit-message line limit is 72 chars (some stupid exception allows 75 in coreboot, but that's not encouraged).