Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34932 )
Change subject: util/cbfstool: new utility pnortool
......................................................................
Patch Set 2:
Patch Set 1:
(1 comment)
About the endianness issue (because I guess not everyone will want to build on a big-endian host ;) :
Maybe you can include src/include/endian.h and use cpu_to_le32(), etc. (you might have to move it to src/common/include first, though, I'm not sure). htonl etc. are technically also an option, but I find them hard to read and this isn't per se about "network" byte order but specifically about big endian (which happens to be the same).
ended up using <commonlib/endian.h>, managed to do the trick.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6566d86a1e025bfe30aa30da36210f49efde3184
Gerrit-Change-Number: 34932
Gerrit-PatchSet: 2
Gerrit-Owner: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 17 Aug 2019 17:30:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment