Attention is currently required from: Evgeny Zinoviev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42455 )
Change subject: nb/intel/sandybridge/gma.c: Correct deasserting force wake on IVB ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Well, maybe there's a chance that somebody in possession of SA BIOS Spec will help us documenting this... :)
Sorry if I was too rude here. I didn't mean to bail out, just lost track of these patches at some point.
It's not that easy. In my copy of the BIOS Spec (maybe the latest maybe not, Intel doesn't provide access to these docs anymore) it says exactly what the code currently does. And that's why the code does it, it was written with the spec at hand.
Now we have documentation of which we don't know if it's the latest and we have refcode of which we don't know if it's the latest and we don't know if Intel updated the documentation at all after the last code changes. The only thing we know is that the code does exactly what was documented. So I say, if we want to change the code, we should document that better. If we don't, somebody might patch the code back to the old state, because that's what was documented.
Documentation starts with the commit message. Currently it says nothing about what was tested.