Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39113 )
Change subject: soc/intel/tigerlake: Add Jasper Lake GPIO definitions ......................................................................
Patch Set 2:
(3 comments)
Patch Set 2:
Hi Karthik , there is a similar patch posted here: https://review.coreboot.org/c/coreboot/+/39111, can we pick that instead?
Of course we can pick that CL. I was looking for the CL to configure GPIOs. Since I did not find one, I started working on it. We can drop this one in favor of your CL.
https://review.coreboot.org/c/coreboot/+/39113/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39113/2/src/soc/intel/tigerlake/acp... PS2, Line 15: : #if CONFIG(SOC_INTEL_TIGERLAKE) : #include "gpio_tgl.asl" : #else : #include "gpio_jsl.asl" : #endif
These two files are nearly identical. The only differences I see are: […]
Lets us move the review to the other CL: https://review.coreboot.org/c/coreboot/+/39111
https://review.coreboot.org/c/coreboot/+/39113/2/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_jsl.c:
https://review.coreboot.org/c/coreboot/+/39113/2/src/soc/intel/tigerlake/gpi... PS2, Line 125: ,
Just to clarify, TGL does not have a COMM_3?
Both TGL and JSL have COMM_3, but they are not exposed to be used.
https://review.coreboot.org/c/coreboot/+/39113/2/src/soc/intel/tigerlake/gpi... PS2, Line 185: TODO
file a bug?
The other CL: https://review.coreboot.org/c/coreboot/+/39111 seems to be handling this. So let us move all our discussion there.