Name of user not set #1002873 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 85: tool
toolchain […]
Done
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 89: Compiler for the host : _must_ support the same language standards as the target compiler.
This needs to be the first sentence in this section, as it is a requirement. […]
Yes, I should change the order of sentences in this paragraph. I kept the description of nice-to-have here for simplicity, no need for extra bullet under "Desirables".
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 106: * Same language for tests and code : : Unit tests will be written in C, because coreboot code is also written in C
This might be a requirement, not a desirable. […]
Actually I was thinking exactly about this, when moving this bullet from Requirements here - don't want to have a must-have which is broken by GoogleTest immediately. But let's keep it simple and follow your suggestion. After all this _requirement_ is the main reason why we don't choose GoogleTest.