Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 18:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG@12 PS18, Line 12: Verified sending HECI global reset message on CML RVP & Hatch board
verified on ICL and SKL or KBL too?
Plans to verify on ICL/SKL.
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 617: GBL RST
Done
It requires brackets,otherwise bot will complains!
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... PS18, Line 572: int send_heci_global_reset_req_message(uint8_t rst_type)
Since this function supports all the HOST, CSE and GLOBAL reset types can we change/retain the earli […]
The function is named to align with HECI command.
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... PS18, Line 114: u8
declaration and definition needs to be aligned.
This is named as per HECI command.