[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add CometLake SoC support

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )

Change subject: soc/intel/cannonlake: Add CometLake SoC support
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig@275 
PS1, Line 275: CometLakeFspBinPkg
I think cml fsp headers are not in intelfsp/FSP yet, might need to set default to vendorcode

https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig@282 
PS1, Line 282: 3rdparty/fsp/CometLakeFspBinPkg/Fsp.fd
not valid for cometlake