Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: isoc/intel/tigerlake: Fix acpi path for gpio ......................................................................
Patch Set 4:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/tigerlake: Fix acpi path for gpio.
Please remove the dot at the end.
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: In
s/In/The […]
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: kernel
What version?
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: list
lists
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: Tigerlake
Tiger Lake
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: the
drop `the`
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: have
has
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: with
Remove?
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: separte
separate
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@18 PS3, Line 18: generates
generated
Ack