21 Dec
2022
21 Dec
'22
5:13 p.m.
Attention is currently required from: Furquan Shaikh, Matt DeVillier.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48859 )
Change subject: ec/google/chromeec: Guard battery-related ACPI code ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: Should this be done for beltino and jecht as well?
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/48859/comment/54b4c356_257d13be PS1, Line 266: EC_NO_BATTERY_PRESENT
it would appear not, if battery. […]
You could move the guards to not hide the debug prints.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41df5a925c9a15553d9e818a2efed2210311fd45
Gerrit-Change-Number: 48859
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan.m.shaikh@gmail.com
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment