Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44841 )
Change subject: mb/roda/rk886ex: Use PNP_IDX_EN instead of magic number ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44841/1/src/mainboard/roda/rk886ex/... File src/mainboard/roda/rk886ex/early_init.c:
https://review.coreboot.org/c/coreboot/+/44841/1/src/mainboard/roda/rk886ex/... PS1, Line 54: pnp_write_config(dev, PNP_IDX_EN, (0x600 >> 4)); /* Runtime Register Block Base */ not sure if this is semantically correct, since this is also a SMSC SIO chip; see my comment on the other patch