Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42792 )
Change subject: libpayload: cbgfx: Replace bilinear resampling with Lanczos ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42792/14/payloads/libpayload/driver... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/42792/14/payloads/libpayload/driver... PS14, Line 473:
Align with previous line?
Done
https://review.coreboot.org/c/coreboot/+/42792/14/payloads/libpayload/driver... PS14, Line 517: from -2 to 4
Where are the numbers -2 and 4 from? Do you mean […]
Yes. I'm trying to only talk about the 6x6 case in all the basic explanations how stuff works to avoid making it too confusing. I'll add a "(for 6x6)" to clarify.
https://review.coreboot.org/c/coreboot/+/42792/14/payloads/libpayload/driver... PS14, Line 628: weigths
weights
Done
https://review.coreboot.org/c/coreboot/+/42792/14/payloads/libpayload/driver... PS14, Line 651: dim->height < sy - S0
Should it be […]
Woah... yeah, this should have been dim_org all along. Good find, thanks!