Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Nick Kochlowski, Paul Menzel.
Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85195?usp=email )
Change subject: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table
......................................................................
Patch Set 11:
(1 comment)
File src/soc/amd/phoenix/pci_irq_routing.c:
https://review.coreboot.org/c/coreboot/+/85195/comment/b8af95a8_eea21f78?usp... :
PS11, Line 51: * map 1:1. However, this may not be the case for other SoCs.
that 1:1 mapping between the indices of the two sets of registers isn't related to the number of IOHCs in the SoC. there are other SoCs with also only one IOHC that don't have a 1:1 mapping between the indices of the two sets of registers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id014ff3e675831eec42bc46c0a76271341e0e3e4
Gerrit-Change-Number: 85195
Gerrit-PatchSet: 11
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 15:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No