Attention is currently required from: Alexander Couzens.
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79938?usp=email )
Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ......................................................................
mb/lenovo/t530: Remove superfluous comments related to PCI devices
Since all devicetrees from lenovo/t530 are using the reference names for PCI devices now, remove the equivalent comments documenting their function.
Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 3 files changed, 32 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79938/1
diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index becc357..97051a1 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -18,9 +18,9 @@ device domain 0 on subsystemid 0x17aa 0x21f6 inherit
- device ref host_bridge on end # Host bridge - device ref peg10 on end # PCIe bridge for discrete graphics - device ref igd on end # Internal graphics VGA controller + device ref host_bridge on end + device ref peg10 on end + device ref igd on end
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH # GPI routing @@ -53,29 +53,29 @@ register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005"
- device ref xhci on end # USB 3.0 Controller - device ref mei1 on end # Management Engine Interface 1 - device ref mei2 off end # Management Engine Interface 2 - device ref me_ide_r off end # Management Engine IDE-R - device ref me_kt off end # Management Engine KT - device ref gbe on # Intel Gigabit Ethernet + device ref xhci on end + device ref mei1 on end + device ref mei2 off end + device ref me_ide_r off end + device ref me_kt off end + device ref gbe on subsystemid 0x17aa 0x21f3 end - device ref ehci2 on end # USB2 EHCI #2 - device ref hda on end # High Definition Audio - device ref pcie_rp1 on end # PCIe Port #1 - device ref pcie_rp2 on end # PCIe Port #2 - device ref pcie_rp3 on # PCIe Port #3 + device ref ehci2 on end + device ref hda on end + device ref pcie_rp1 on end + device ref pcie_rp2 on end + device ref pcie_rp3 on smbios_slot_desc "7" "3" "ExpressCard Slot" "8" end - device ref pcie_rp4 off end # PCIe Port #4 - device ref pcie_rp5 off end # PCIe Port #5 - device ref pcie_rp6 off end # PCIe Port #6 - device ref pcie_rp7 off end # PCIe Port #7 - device ref pcie_rp8 off end # PCIe Port #8 - device ref ehci1 on end # USB2 EHCI #1 - device ref pci_bridge off end # PCI bridge - device ref lpc on # PCI-LPC bridge + device ref pcie_rp4 off end + device ref pcie_rp5 off end + device ref pcie_rp6 off end + device ref pcie_rp7 off end + device ref pcie_rp8 off end + device ref ehci1 on end + device ref pci_bridge off end + device ref lpc on chip ec/lenovo/pmh7 device pnp ff.1 on end # dummy register "backlight_enable" = "true" @@ -137,8 +137,8 @@ register "has_thinker1" = "1" end end - device ref sata1 on end # SATA Controller 1 - device ref smbus on # SMBus + device ref sata1 on end + device ref smbus on # eeprom, 8 virtual devices, same chip chip drivers/i2c/at24rf08c device i2c 54 on end @@ -151,8 +151,8 @@ device i2c 5f on end end end - device ref sata2 off end # SATA Controller 2 - device ref thermal on end # Thermal + device ref sata2 off end + device ref thermal on end end end end diff --git a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb index e7460a1..4da7219 100644 --- a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb @@ -2,7 +2,7 @@ register "spd_addresses" = "{0x50, 0, 0x51, 0}" device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device ref lpc on # PCI-LPC bridge + device ref lpc on chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "has_wwan_detection" = "1" diff --git a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb index c38bf45..0045c5a 100644 --- a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb @@ -1,26 +1,26 @@ chip northbridge/intel/sandybridge register "spd_addresses" = "{0x50, 0x52, 0x51, 0x53}" device domain 0 on - device ref igd on # Internal graphics VGA controller + device ref igd on subsystemid 0x17aa 0x21f5 end chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device ref me_kt on end # Management Engine KT - device ref pcie_rp1 on # PCIe Port #1 + device ref me_kt on end + device ref pcie_rp1 on chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x83" register "sdwppol" = "1" device pci 00.0 on end # Ricoh SD card reader end end - device ref lpc on # PCI-LPC bridge + device ref lpc on chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "config1" = "0x01" register "config3" = "0xe2" end end - device ref thermal off end # Thermal + device ref thermal off end end end end