Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45343 )
Change subject: device/dram: Add method for converting MHz to MT/s ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45343/2/src/device/dram/ddr4.c File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/2/src/device/dram/ddr4.c@125 PS2, Line 125: >
Why is min exclusive and max inclusive?
Because this is how it's listed in the spec. Some precision will be lost if this isn't followed.
https://review.coreboot.org/c/coreboot/+/45343/2/src/include/device/dram/ddr... File src/include/device/dram/ddr4.h:
https://review.coreboot.org/c/coreboot/+/45343/2/src/include/device/dram/ddr... PS2, Line 90: } ddr4_speed_attr;
No typedefs, please. Also, this object does not need to be exposed out of the compilation unit. […]
Done
https://review.coreboot.org/c/coreboot/+/45343/2/src/include/device/dram/ddr... PS2, Line 93:
Please add comments here what the functions do.
Done