[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Correct FSP log interface for JSL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39280 )

Change subject: soc/intel/tigerlake: Correct FSP log interface for JSL
......................................................................

Patch Set 7:

(3 comments)

I think TGL code needs a similar change as well.

https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/chi... 
File src/soc/intel/tigerlake/chip.h:

https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/chi... 
PS7, Line 196: /* TraceHubMode config
nit: Use consistent multi-line comment format:
/*
 * TraceHubMode ...

https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom... 
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:

https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom... 
PS7, Line 78: 
nit: blank line not required.

https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom... 
PS7, Line 79: config->TraceHubMode != 0
Don't you also need to ensure that the corresponding device in device tree is enabled?