Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39280 )
Change subject: soc/intel/tigerlake: Correct FSP log interface for JSL
......................................................................
Patch Set 7:
(3 comments)
I think TGL code needs a similar change as well.
https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/chi...
PS7, Line 196: /* TraceHubMode config
nit: Use consistent multi-line comment format:
/*
* TraceHubMode ...
https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom...
PS7, Line 78:
nit: blank line not required.
https://review.coreboot.org/c/coreboot/+/39280/7/src/soc/intel/tigerlake/rom...
PS7, Line 79: config->TraceHubMode != 0
Don't you also need to ensure that the corresponding device in device tree is enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7be7f93082f9c64c1c45963d70ee2e3b3d29986a
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 7
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 08:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment