Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48408 )
Change subject: nb/intel/sandybridge: Clean up stepping logic ......................................................................
Patch Set 3:
(3 comments)
Thanks for updating the commit message!
https://review.coreboot.org/c/coreboot/+/48408/3/src/cpu/intel/model_206ax/m... File src/cpu/intel/model_206ax/model_206ax.h:
https://review.coreboot.org/c/coreboot/+/48408/3/src/cpu/intel/model_206ax/m... PS3, Line 95: } Actually, this code is not model specific.
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... PS3, Line 277: is_sandy && I read `!is_sandy ||`?
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... PS3, Line 282: is_sandy && Same here?