Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49016/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49016/3//COMMIT_MSG@19 PS3, Line 19: Create MAINBOARD_HAS_DGPU_VGA_INIT Kconfig for mainboard to select design : with DGPU where OpROM is embedded inside the DGPU card. : : TEST=Able to get Pre-OS splash screen with PCI-E DGPU when mainboard user Overlong lines.
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig@49 PS3, Line 49: config MAINBOARD_HAS_DGPU_VGA_INIT DGPU doesn't always imply that we need to run a VGA OpROM (we have native coreboot drivers for some discrete chips (e.g. ASpeed), and I hope for DG1 we are able to extend libgfxinit; I have lower hopes for AMD and Nvidia chips).
Maybe name this simply by its intended effect, e.g. `VGA_ROM_RUN_DEFAULT`?
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig@64 PS3, Line 64: PAYLOAD_SEABIOS This is supposed to guard us from a wrong VGA_ROM_RUN default in case SeaBIOS is used (it would run the VBIOS again). I guess this needs to be updated to
default NO_GFX_INIT if (VGA_BIOS || MAINBOARD_HAS_DGPU_VGA_INIT) && PAYLOAD_SEABIOS