3 comments:
Create MAINBOARD_HAS_DGPU_VGA_INIT Kconfig for mainboard to select design
with DGPU where OpROM is embedded inside the DGPU card.
TEST=Able to get Pre-OS splash screen with PCI-E DGPU when mainboard user
Overlong lines.
Patch Set #3, Line 49: config MAINBOARD_HAS_DGPU_VGA_INIT
DGPU doesn't always imply that we need to run a VGA OpROM (we have native
coreboot drivers for some discrete chips (e.g. ASpeed), and I hope for
DG1 we are able to extend libgfxinit; I have lower hopes for AMD and Nvidia
chips).
Maybe name this simply by its intended effect, e.g. `VGA_ROM_RUN_DEFAULT`?
Patch Set #3, Line 64: PAYLOAD_SEABIOS
This is supposed to guard us from a wrong VGA_ROM_RUN default in
case SeaBIOS is used (it would run the VBIOS again). I guess this
needs to be updated to
default NO_GFX_INIT if (VGA_BIOS || MAINBOARD_HAS_DGPU_VGA_INIT) && PAYLOAD_SEABIOS
To view, visit change 49016. To unsubscribe, or for help writing mail filters, visit settings.