build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm STM support ......................................................................
Patch Set 2:
(262 comments)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@178 PS2, Line 178: ResourceHi = (uint64_t) Resource->Io.Base + code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@178 PS2, Line 178: ResourceHi = (uint64_t) Resource->Io.Base + please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@178 PS2, Line 178: ResourceHi = (uint64_t) Resource->Io.Base + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@181 PS2, Line 181: RecordHi = (uint64_t) Record->Io.Base + code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@181 PS2, Line 181: RecordHi = (uint64_t) Record->Io.Base + please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@181 PS2, Line 181: RecordHi = (uint64_t) Record->Io.Base + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@185 PS2, Line 185: if ((Resource->PciCfg.OriginatingBusNumber != suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@188 PS2, Line 188: Record->PciCfg.LastNodeIndex)) trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@190 PS2, Line 190: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@191 PS2, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath, suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@191 PS2, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@201 PS2, Line 201: RecordHi = (uint64_t) Record->PciCfg.Base + trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@218 PS2, Line 218: // Special case - merge MSR masks in place. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@218 PS2, Line 218: // Special case - merge MSR masks in place. please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@218 PS2, Line 218: // Special case - merge MSR masks in place. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@219 PS2, Line 219: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@219 PS2, Line 219: // please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@219 PS2, Line 219: // please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@222 PS2, Line 222: Record->Msr.ReadMask |= Resource->Msr.ReadMask; trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@223 PS2, Line 223: Record->Msr.WriteMask |= Resource->Msr.WriteMask; trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@232 PS2, Line 232: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@232 PS2, Line 232: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@232 PS2, Line 232: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@236 PS2, Line 236: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@240 PS2, Line 240: // Resources are overlapping. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@240 PS2, Line 240: // Resources are overlapping. please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@240 PS2, Line 240: // Resources are overlapping. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@241 PS2, Line 241: // Resource and record are merged. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@241 PS2, Line 241: // Resource and record are merged. please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@241 PS2, Line 241: // Resource and record are merged. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@242 PS2, Line 242: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@242 PS2, Line 242: // please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@242 PS2, Line 242: // please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@246 PS2, Line 246: switch (Resource->Header.RscType) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@246 PS2, Line 246: switch (Resource->Header.RscType) { please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@246 PS2, Line 246: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@251 PS2, Line 251: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@251 PS2, Line 251: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@251 PS2, Line 251: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@254 PS2, Line 254: Record->Io.Base = (uint64_t) ResourceLo; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@254 PS2, Line 254: Record->Io.Base = (uint64_t) ResourceLo; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@254 PS2, Line 254: Record->Io.Base = (uint64_t) ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@255 PS2, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@255 PS2, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@255 PS2, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@256 PS2, Line 256: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@256 PS2, Line 256: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@256 PS2, Line 256: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@260 PS2, Line 260: break; trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@262 PS2, Line 262: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@262 PS2, Line 262: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@262 PS2, Line 262: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@288 PS2, Line 288: Record = (STM_RSC *)((void *)Record + Record->Header.Length); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@289 PS2, Line 289: continue; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@289 PS2, Line 289: continue; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@289 PS2, Line 289: continue; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@294 PS2, Line 294: if (HandleSingleResource (Resource, Record)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@294 PS2, Line 294: if (HandleSingleResource (Resource, Record)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@295 PS2, Line 295: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@296 PS2, Line 296: } trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@296 PS2, Line 296: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@296 PS2, Line 296: } please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@296 PS2, Line 296: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@303 PS2, Line 303: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@308 PS2, Line 308: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@309 PS2, Line 309: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@314 PS2, Line 314: mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed; line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@316 PS2, Line 316: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@317 PS2, Line 317: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@334 PS2, Line 334: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@341 PS2, Line 341: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@341 PS2, Line 341: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@343 PS2, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES) code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@343 PS2, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES) please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@343 PS2, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@344 PS2, Line 344: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@345 PS2, Line 345: AddSingleResource (Resource); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@346 PS2, Line 346: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@348 PS2, Line 348: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@349 PS2, Line 349: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@357 PS2, Line 357: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@372 PS2, Line 372: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@373 PS2, Line 373: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@374 PS2, Line 374: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@376 PS2, Line 376: } else { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@382 PS2, Line 382: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@384 PS2, Line 384: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@384 PS2, Line 384: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@386 PS2, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@386 PS2, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@388 PS2, Line 388: // Validate resource. trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@389 PS2, Line 389: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@392 PS2, Line 392: if (Resource->Header.Length != sizeof (STM_RSC_END)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@394 PS2, Line 394: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@395 PS2, Line 395: // If we are passed actual number of resources to add, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@396 PS2, Line 396: // END_OF_RESOURCES structure between them is considered an code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@397 PS2, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@397 PS2, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@398 PS2, Line 398: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@401 PS2, Line 401: } else { else is not generally useful after a break or return
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@402 PS2, Line 402: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@403 PS2, Line 403: // If NumEntries == 0 and list reached end - return success. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@404 PS2, Line 404: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@404 PS2, Line 404: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@411 PS2, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@411 PS2, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@417 PS2, Line 417: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@417 PS2, Line 417: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@417 PS2, Line 417: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@419 PS2, Line 419: case TRAPPED_IO_RANGE: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@420 PS2, Line 420: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@428 PS2, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@428 PS2, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@429 PS2, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@429 PS2, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@431 PS2, Line 431: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@432 PS2, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@432 PS2, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@436 PS2, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@436 PS2, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@436 PS2, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@436 PS2, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@436 PS2, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@437 PS2, Line 437: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@437 PS2, Line 437: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@437 PS2, Line 437: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@438 PS2, Line 438: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@438 PS2, Line 438: } please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@438 PS2, Line 438: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@439 PS2, Line 439: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@439 PS2, Line 439: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@439 PS2, Line 439: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@442 PS2, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@442 PS2, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@442 PS2, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@446 PS2, Line 446: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@446 PS2, Line 446: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@446 PS2, Line 446: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@448 PS2, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@448 PS2, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@451 PS2, Line 451: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@453 PS2, Line 453: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@453 PS2, Line 453: return true; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@453 PS2, Line 453: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@479 PS2, Line 479: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@480 PS2, Line 480: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@481 PS2, Line 481: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@482 PS2, Line 482: Count = 0xFFFFFFFF; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@482 PS2, Line 482: Count = 0xFFFFFFFF; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@482 PS2, Line 482: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@489 PS2, Line 489: // trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@493 PS2, Line 493: if (Resource->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@511 PS2, Line 511: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@521 PS2, Line 521: printk(BIOS_DEBUG, "AddPiResource - Enter\n"); Prefer using '"%s...", __func__' to using 'AddPiResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@523 PS2, Line 523: if (!ValidateResource (ResourceList, NumEntries)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@523 PS2, Line 523: if (!ValidateResource (ResourceList, NumEntries)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@527 PS2, Line 527: ResourceSize = GetResourceSize (ResourceList, NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@528 PS2, Line 528: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@529 PS2, Line 529: if (ResourceSize == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@535 PS2, Line 535: // Copy EndResource for intialization 'intialization' may be misspelled - perhaps 'initialization'?
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@544 PS2, Line 544: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@546 PS2, Line 546: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@552 PS2, Line 552: } else if (mStmResourceSizeAvailable < ResourceSize) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@584 PS2, Line 584: // TBD code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@584 PS2, Line 584: // TBD please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@584 PS2, Line 584: // TBD please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@585 PS2, Line 585: //ASSERT (false); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@585 PS2, Line 585: //ASSERT (false); please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@585 PS2, Line 585: //ASSERT (false); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@591 PS2, Line 591: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@593 PS2, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@593 PS2, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@593 PS2, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@604 PS2, Line 604: or the size of resource list to be filled if size of too small. line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@607 PS2, Line 607: @retval BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@612 PS2, Line 612: if (*ResourceSize < mStmResourceSizeUsed) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@617 PS2, Line 617: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@618 PS2, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@618 PS2, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@618 PS2, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@619 PS2, Line 619: return 0;//EFI_SUCCESS; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@619 PS2, Line 619: return 0;//EFI_SUCCESS; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@619 PS2, Line 619: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@633 PS2, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@633 PS2, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@637 PS2, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@637 PS2, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@637 PS2, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@637 PS2, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); Prefer using '"%s...", __func__' to using 'GetVmcsSize', this function's name, in a string
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@642 PS2, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@642 PS2, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@657 PS2, Line 657: UINTN Index; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@657 PS2, Line 657: UINTN Index; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@657 PS2, Line 657: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@661 PS2, Line 661: Pte = (uint32_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@664 PS2, Line 664: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@670 PS2, Line 670: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@671 PS2, Line 671: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@689 PS2, Line 689: Pml4 = (uint64_t*)(uint32_t) PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@693 PS2, Line 693: Pde = (uint64_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@702 PS2, Line 702: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof(*Pte); SubIndex++) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@703 PS2, Line 703: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@708 PS2, Line 708: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@709 PS2, Line 709: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@725 PS2, Line 725: STM_HEADER *StmHeader; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@732 PS2, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@732 PS2, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@732 PS2, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@734 PS2, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@734 PS2, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@735 PS2, Line 735: if (MinMsegSize < StmImageSize) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@739 PS2, Line 739: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@743 PS2, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@743 PS2, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@744 PS2, Line 744: MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@751 PS2, Line 751: if (MinMsegSize > CONFIG_MSEG_SIZE) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@781 PS2, Line 781: //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@785 PS2, Line 785: if (sizeof(UINTN) == sizeof(uint64_t)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@786 PS2, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@786 PS2, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@788 PS2, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@788 PS2, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@804 PS2, Line 804: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@814 PS2, Line 814: if (SmmMonCtlMsr.bits.MsegAddress == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@822 PS2, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@822 PS2, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@827 PS2, Line 827: // Record STM_HASH to PCR 0, just in case it is NOT TXT launch, we still need provide the evidence. line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@833 PS2, Line 833: (void *)StmImage, // HashData code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@833 PS2, Line 833: (void *)StmImage, // HashData please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@833 PS2, Line 833: (void *)StmImage, // HashData please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@837 PS2, Line 837: StmLoadStmImage (StmImage, StmImageSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@838 PS2, Line 838: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@838 PS2, Line 838: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/SmmStm.c@838 PS2, Line 838: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h File src/security/intel/stm/StmApi.h:
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@155 PS2, Line 155: uint64_t AcpiRsdp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@155 PS2, Line 155: uint64_t AcpiRsdp; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@155 PS2, Line 155: uint64_t AcpiRsdp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@156 PS2, Line 156: uint8_t PhysicalAddressBits; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@156 PS2, Line 156: uint8_t PhysicalAddressBits; please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@156 PS2, Line 156: uint8_t PhysicalAddressBits; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@247 PS2, Line 247: uint32_t Cr4; // fe40h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@247 PS2, Line 247: uint32_t Cr4; // fe40h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@247 PS2, Line 247: uint32_t Cr4; // fe40h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@253 PS2, Line 253: uint32_t IdtLimit; // fe98h : NO trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@258 PS2, Line 258: uint32_t LdtInfo; // fea4h : NO trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@266 PS2, Line 266: uint32_t SMMRevId; // fefch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@266 PS2, Line 266: uint32_t SMMRevId; // fefch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@266 PS2, Line 266: uint32_t SMMRevId; // fefch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@505 PS2, Line 505: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@507 PS2, Line 507: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@508 PS2, Line 508: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@509 PS2, Line 509: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmApi.h@751 PS2, Line 751: #pragma pack (pop) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 143: // Index Read Write trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 167: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1); line over 80 characters
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 206: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 206: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 240: trailing whitespace
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformRe... PS2, Line 240: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformSm... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformSm... PS2, Line 61: StmGen4GPageTableX64 ((uint32_t)MsegBase + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformSm... PS2, Line 79: struct descriptor{ missing space after struct definition
https://review.coreboot.org/#/c/33234/2/src/security/intel/stm/StmPlatformSm... PS2, Line 87: void ReadGdtr( struct descriptor *gdtr) space prohibited after that open parenthesis '('