Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )
Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................
Patch Set 3:
Patch Set 3:
Okay what do I need to get this resolved?
I created these defines so that in the code the reader would be able to see that the values being placed into the data structure (smm descriptor) are for smm descriptors.
Just let me know.
Since it's a pretty small change, maybe squash it into CB:33234 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd163a1687b7e6bd4345895b6349d716b8b3b5c2
Gerrit-Change-Number: 38520
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 19:17:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment