Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... File src/soc/intel/cannonlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 110: else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y)
also check that CONFIG_SOC_INTEL_CANNONLAKE_PCH_H != y
Done