Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42484 )
Change subject: mb/pcengines/apu2: Update GPIO Reads & writes ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 1: Code-Review+2
Patch Set 1:
I'm not even sure why there is code like this in mainboard to begin with.
It is used to turn off the LEDs in the final booting stage. Also helps indicating a normal user that the boot process is finished
The comment was really about the quality of the code, not its existence. Or that's how I interpreted it. Expect to see a revert/rewrite of this in near future, apuX was sort of abusing the acpimmio/gpio_banks API.
Yes, that the intention of my comment, Michał. It wasn't the functionality it was the implementation. We largely try to keep chipset specific implementation knowledge out of mainboard implementations and defer to the chipset code to provide the necessary abstractions.