Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31822 )
Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
......................................................................
Patch Set 4:
This looks like a severe compiler bug, please don't
just work around it. It seems the compiler precalcu-
lates the correct numbers, but places 0s into the
Memory32Fixed resource and the numbers after it,
amidst the bytestream:
Buffer that contains 14B:
11 11 0a 0e
The memory range filled with 0s:
86 09 00 00 00 00 00 00 00 00 00 00
End Tag:
79 00
After the buffer our numbers:
00 00 80 ff 00 00 80 00
Please let me know if you don't want to check if the
issue persists upstream and report this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a47bf2600f546271c5a65641d29f868ff2748bf
Gerrit-Change-Number: 31822
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Apr 2019 11:39:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment