[coreboot-gerrit] Change in ...coreboot[master]: util/superiotool: Add AST2400

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32984 )

Change subject: util/superiotool: Add AST2400
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/32984/2/util/superiotool/aspeed.c 
File util/superiotool/aspeed.c:

https://review.coreboot.org/#/c/32984/2/util/superiotool/aspeed.c@81 
PS2, Line 81: 	};
> So 0x1150 is a PCI-to-PCI bridge with 0x2000 "graphics family" device on the secondary? […]

Yes, the VGA device might be disabled.
Also as all Aspeed BMC use the same vendor/device id for PCI devices, it's not a very good indicator.

https://review.coreboot.org/#/c/32984/2/util/superiotool/aspeed.c@100 
PS2, Line 100: 	 * Together with PCI detection that should be sufficient.
> From what I remember, outside the config mode, decoders are passive for the configuration registers  […]

I'll improve the check based on that.