Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44739 )
Change subject: soc/intel/cnl: Allow enabling/disabling GNA device
......................................................................
Patch Set 3: Code-Review+1
Patch Set 3:
Sorry for being picky, but is this really a mainboard option?
Is there anything a mainboard design has to provide to make
it work? Or is it rather a user option if they want to make use
of that device?
I'm inclined to agree here. I wasn't able to find out that much about the device but AFAIU this is dependent on board desin. Let's make that a Kconfig option instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I921e29bfc77c8096519b52fec8bb6b2193006f99
Gerrit-Change-Number: 44739
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 29 Aug 2020 13:53:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment