[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
PS2, Line 89: 	size_mb = (1U << fb_pow);
> I see why you would want to change this, but what if fb_pow is, e.g. […]

fb_pow is bounded by the number of bits in size_mb, so it can only be up to 31 (which then can't cause any overflow when shifting)