Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Paul Menzel.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84375?usp=email )
Change subject: soc/amd/glinda: Update pci int defs
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84375/comment/d25f779b_7ae78fa9?usp... :
PS5, Line 8:
A summary of the changes would be nice.
It is basically just checking which IRQs are still present in the datasheet and updating them accordingly. The code diff is basically the best summary for this particular change.
https://review.coreboot.org/c/coreboot/+/84375/comment/9b165ff6_1f3444ed?usp... :
PS5, Line 11:
Were you able to boot test this?
I tested it on the birman+. But with a lot patches in between that I am going to upstream soon for the birman+ board. I just wanted to avoid creating 1 big patch train.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I843e5e2b01301eb02cb5be347e122cffbe76d80d
Gerrit-Change-Number: 84375
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 30 Sep 2024 10:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org