Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38463 )
Change subject: mainboard/system76: Add System76 Lemur Pro (lemp9)
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38463/14/src/mainboard/system76/lem...
File src/mainboard/system76/lemp9/Kconfig:
https://review.coreboot.org/c/coreboot/+/38463/14/src/mainboard/system76/lem...
PS14, Line 85:
: config FSP_M_XIP
: bool
: default y
this shouldn't be here. the Kconfig option is in src/drivers/intel/fsp2_0/Kconfig and it gets selected in src/soc/intel/cannonlake/Kconfig and that gets selected by SOC_INTEL_COMETLAKE. please test if this breaks anything and if not submit a patch. feel free to add me as reviewer there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0a32bbc6f89a662085ab4a254676bc1fad7dc60
Gerrit-Change-Number: 38463
Gerrit-PatchSet: 14
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment