Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37607 )
Change subject: superio/common/generic: Assign resources behind device
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG@10
PS1, Line 10: need to scan the complete 'bus' even though it is not a bridge.
Can you elaborate why it has to be the parent? i.e. why can't we do the same […]
1. There can be multiple siblings, we would need to reference one somehow (either in C or in ACPI)
2. Disabled devices do not generate SSDTs
With the parent/child approach that's not needed as there's only one parent, it's enabled by default and the ACPI path is known.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id80a2ae6e82c151b8d8adc9c5f35f38362d538fa
Gerrit-Change-Number: 37607
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 13:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment