Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb: add new board clevo/tgl-u/l140mu ......................................................................
Patch Set 8:
(6 comments)
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/15799f0b_c70ed104 PS8, Line 94: PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* I2C1_SDA / PCH_I2C_SDA (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/56258d1a_bd2427b1 PS8, Line 95: PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* I2C1_SCL / PCH_I2C_SCL (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/33272449_5de0f2d1 PS8, Line 99: PAD_NC(GPP_C23, UP_20K), /* GPP_C23 / PCH_GPP_C23 (WLAN_WAKEUP#) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/dcc289cb_a28f6d35 PS8, Line 104: PAD_NC(GPP_D2, NONE), /* LEDKB_DET# (unused; not sold w/o KBLED) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/8ffcbffb_45d5e458 PS8, Line 107: PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* SRCCLKREQ0# / SSD1_CLKREQ# (for SSD2!) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144767): https://review.coreboot.org/c/coreboot/+/59548/comment/9e90b916_c87d410d PS8, Line 110: PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* SRCCLKREQ3# / SSD2_CLKREQ# (for SSD1!) */ line over 96 characters