Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33409 )
Change subject: nb/intel/x4x: Die on unknown memory speed
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33409/1/src/northbridge/intel/x4x/raminit_dd...
File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/#/c/33409/1/src/northbridge/intel/x4x/raminit_dd...
PS1, Line 45: DDR2
this function has nothing to do with DDR2
I guess the confusion may have arisen because of the function name. I am pretty sure it means "DDR to MHz".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib628c0eed3d6571bdde1df27ae213ca0691ec256
Gerrit-Change-Number: 33409
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Jun 2019 08:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment