[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/dmi: Add DMI driver support

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47988 )

Change subject: soc/intel/common/dmi: Add DMI driver support
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47988/9/src/soc/intel/common/block/... 
File src/soc/intel/common/block/dmi/dmi.c:

https://review.coreboot.org/c/coreboot/+/47988/9/src/soc/intel/common/block/... 
PS9, Line 52: 64
could use DMI_PCR_GPMR_BASE_MASK instead of hardcoding.  not likely to change so it isn't a big deal.

https://review.coreboot.org/c/coreboot/+/47988/9/src/soc/intel/common/block/... 
PS9, Line 70: -1
could use CB_ERR for this (and the return value in get_available_gpmr) as well