Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81437/comment/22808f7a_b9aaf609 :
PS3, Line 15: [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for
: 21 to use_ddr4_params
Please use one line and indent it by four spaces.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id78ef90c0dc2e869c1f0424674b982ba64ba3939
Gerrit-Change-Number: 81437
Gerrit-PatchSet: 3
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 26 Mar 2024 11:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment