Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47116 )
Change subject: soc/intel/skylake: Enable PCH thermal depending on devicetree ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... PS2, Line 285: params->PchThermalDeviceEnable = dev && dev->enabled;
intel/kblrvp/variants/rvp11/overridetree.cb : off -> dev is currently on - will be off kontron/bsl6/devicetree.cb : not defined -> dev is currently on - will be off intel/saddlebrook/devicetree.cb : off -> dev is currently on - will be off
This change is for the *PCH* thermal subsystem - `pci 14.2`, not the *SA* thermal subsystem - `pci 04.0`. Sorry if there was any confusion.
protectli/vault_kbl/devicetree.cb : off -> dev is currently on - will be off
Behaviour will be preserved as the UPD was being disabled in protectli/vault_kbl/ramstage.c